search

JuliaManifolds / Manifolds.jl

Manifolds.jl provides a library of manifolds aiming for an easy-to-use and fast implementation.
https://juliamanifolds.github.io/Manifolds.jl
MIT License
368 stars 53 forks source link

Introduction of the orthographic retraction for the fixed rank manifold #662

Closed Klingbiel closed 10 months ago

codecov[bot] commented 10 months ago

Codecov Report

Merging #662 (62dcf0e) into master (3536123) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #662   +/-   ##
=======================================
  Coverage   99.40%   99.40%           
=======================================
  Files         108      108           
  Lines       10567    10593   +26     
=======================================
+ Hits        10504    10530   +26     
  Misses         63       63
Files Coverage Δ
ext/ManifoldsTestExt/tests_general.jl 95.72% <100.00%> (+0.04%) :arrow_up:
src/Manifolds.jl 86.66% <ø> (ø)
src/manifolds/FixedRankMatrices.jl 98.88% <100.00%> (+0.09%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

kellertuer commented 10 months ago

Since we had some (breaking) changes in ManifoldsBase (concerning especially the data flow / allocation flow for retractions) and Manifolds (concerning statically parametrised manifolds) I just adapted this PR to those changes.

@Klingbiel could you check the comments above?