search

JuliaManifolds / Manifolds.jl

Manifolds.jl provides a library of manifolds aiming for an easy-to-use and fast implementation.
https://juliamanifolds.github.io/Manifolds.jl
MIT License
368 stars 53 forks source link

Fix #665 #666

Closed mateuszbaran closed 10 months ago

mateuszbaran commented 10 months ago

Fixes #665 , and one other minor bug with is_vector.

kellertuer commented 10 months ago

Ah, I saw in other Changelogs, that they would link to errors/issues that are resolved by changes, do we want to do the same? Might be nice in the rendered docs.

mateuszbaran commented 10 months ago

I'm not sure, I haven't checked what we did before.

Sure, I can add a link to the issue that was fixed.

codecov[bot] commented 10 months ago

Codecov Report

Merging #666 (c0b3b7f) into master (b0ab892) will increase coverage by 0.00%. Report is 1 commits behind head on master. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #666   +/-   ##
=======================================
  Coverage   99.40%   99.40%           
=======================================
  Files         108      108           
  Lines       10593    10597    +4     
=======================================
+ Hits        10530    10534    +4     
  Misses         63       63
Files Coverage Δ
src/groups/GroupManifold.jl 100.00% <100.00%> (ø)
src/groups/general_unitary_groups.jl 100.00% <100.00%> (ø)
src/groups/translation_group.jl 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more