search

JuliaManifolds / Manifolds.jl

Manifolds.jl provides a library of manifolds aiming for an easy-to-use and fast implementation.
https://juliamanifolds.github.io/Manifolds.jl
MIT License
368 stars 53 forks source link

Doc improvements for `apply_diff_group` #671

Closed olivierverdier closed 10 months ago

codecov[bot] commented 10 months ago

Codecov Report

Merging #671 (9a2440a) into master (4fce452) will increase coverage by 0.03%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #671      +/-   ##
==========================================
+ Coverage   99.36%   99.40%   +0.03%     
==========================================
  Files         108      108              
  Lines       10597    10597              
==========================================
+ Hits        10530    10534       +4     
+ Misses         67       63       -4
Files Coverage Δ
src/groups/group_action.jl 94.44% <ø> (ø)

... and 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

olivierverdier commented 10 months ago

Closing this, as there is no consensus on the formulation, and I seriously doubt my ability to explain things clearly enough. [1], [2] (The first commit in this PR is however just a typo, so that one could be merged, I guess).

mateuszbaran commented 10 months ago

We can definitely rethink our notation but it needs to be carefully considered, and the current one is not bad enough in my opinion that we would have to rush any improvements. We can definitely merge the first PR though.

I'm currently considering introduction of the (1,r)-velocity formalism from Kolar's book for higher order rigid body dynamics. Maybe it will provide some insights related to our considerations about differentials.