search

JuliaManifolds / Manifolds.jl

Manifolds.jl provides a library of manifolds aiming for an easy-to-use and fast implementation.
https://juliamanifolds.github.io/Manifolds.jl
MIT License
368 stars 53 forks source link

Update for BoundaryValueDiffEq v5 #672

Closed mateuszbaran closed 10 months ago

mateuszbaran commented 10 months ago

This may resolve the never-ending solving problem on BoundaryValueDiffEq v5. Resolves #664 . Replaces #657 .

codecov[bot] commented 10 months ago

Codecov Report

Merging #672 (58c9681) into master (cdf3f6c) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #672   +/-   ##
=======================================
  Coverage   99.40%   99.40%           
=======================================
  Files         108      108           
  Lines       10599    10600    +1     
=======================================
+ Hits        10536    10537    +1     
  Misses         63       63
Files Coverage Δ
ext/ManifoldsBoundaryValueDiffEqExt.jl 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

mateuszbaran commented 10 months ago

This even looks like a relatively easy fix in the end – are we sure the new tests run on v5? And then maybe check why we currently loose a bit of coverage.

Yes, Julia v1.9 tests run on BoundaryValueDiffEq v5 while Julia v1.6 tests run on BoundaryValueDiffEq v4. I just don't feel particularly good about tests running more than an hour :disappointed: .

Coverage loss looks like false positives.