search

JuliaManifolds / Manifolds.jl

Manifolds.jl provides a library of manifolds aiming for an easy-to-use and fast implementation.
https://juliamanifolds.github.io/Manifolds.jl
MIT License
368 stars 53 forks source link

Adapt to recent vee/hat change in ManifoldsBase #680

Closed mateuszbaran closed 10 months ago

mateuszbaran commented 10 months ago

https://github.com/JuliaManifolds/ManifoldsBase.jl/pull/173 broke some tests here and this fixes them.

codecov[bot] commented 10 months ago

Codecov Report

Merging #680 (caade58) into master (2104bef) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #680      +/-   ##
==========================================
- Coverage   99.57%   99.56%   -0.01%     
==========================================
  Files         108      108              
  Lines       10678    10678              
==========================================
- Hits        10633    10632       -1     
- Misses         45       46       +1
Files Coverage Δ
ext/ManifoldsTestExt/tests_general.jl 99.15% <100.00%> (ø)
src/manifolds/Circle.jl 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

kellertuer commented 10 months ago

Looks good in general to me, besides the loss of one line in codecov?

mateuszbaran commented 10 months ago

That looks completely unrelated to this PR, so I'd ignore it for now.