Closed github-actions[bot] closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
b2d83b3
) 99.57% compared to head (8d3681a
) 44.16%. Report is 2 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This failure looks like something we need to investigate before merging:
Hessian conversion: Error During Test at /home/runner/work/Manifolds.jl/Manifolds.jl/test/manifolds/product_manifold.jl:341
Got exception outside of a @test
DimensionMismatch: dimensions must match: a has dims (Base.OneTo(1),), b has dims (Base.OneTo(3),), mismatch at 1
Stacktrace:
[1] promote_shape(a::AbstractArray, b::AbstractArray)
@ Base ./indices.jl:178 [inlined]
[2] promote_shape(a::AbstractArray, b::AbstractArray)
@ Base ./indices.jl:169 [inlined]
[3] -(A::Vector{Float64}, B::Vector{Float64})
@ Base ./arraymath.jl:7
[4] riemannian_Hessian!(M::Sphere{TypeParameter{Tuple{2}}, ℝ}, Y::Vector{Float64}, p::Vector{Float64}, eG::Vector{Float64}, eH::Vector{Float64}, X::Vector{Float64})
@ ManifoldDiff ~/.julia/packages/ManifoldDiff/TFtNd/src/riemannian_diff.jl:360
[5] riemannian_Hessian(M::Sphere{TypeParameter{Tuple{2}}, ℝ}, p::Vector{Float64}, eG::Vector{Float64}, eH::Vector{Float64}, X::Vector{Float64})
@ ManifoldDiff ~/.julia/packages/ManifoldDiff/TFtNd/src/riemannian_diff.jl:355
[6] (::var"#237#242"{ArrayPartition{Float64, Tuple{Vector{Float64}, Vector{Float64}}}, ArrayPartition{Float64, Tuple{Vector{Float64}, Vector{Float64}}}, ArrayPartition{Float64, Tuple{Vector{Float64}, Vector{Float64}}}, ArrayPartition{Float64, Tuple{Vector{Float64}, Vector{Float64}}}, Sphere{TypeParameter{Tuple{2}}, ℝ}})(i::Int64)
@ Main ./none:0
[7] iterate(g::Base.Generator, s::Vararg{Any})
@ Base ./generator.jl:47 [inlined]
[8] collect(itr::Base.Generator{UnitRange{Int64}, var"#237#242"{ArrayPartition{Float64, Tuple{Vector{Float64}, Vector{Float64}}}, ArrayPartition{Float64, Tuple{Vector{Float64}, Vector{Float64}}}, ArrayPartition{Float64, Tuple{Vector{Float64}, Vector{Float64}}}, ArrayPartition{Float64, Tuple{Vector{Float64}, Vector{Float64}}}, Sphere{TypeParameter{Tuple{2}}, ℝ}}})
@ Base ./array.jl:834
[9] macro expansion
@ ~/work/Manifolds.jl/Manifolds.jl/test/manifolds/product_manifold.jl:352 [inlined]
[10] macro expansion
@ /opt/hostedtoolcache/julia/1.10.0-rc3/x64/share/julia/stdlib/v1.10/Test/src/Test.jl:1577 [inlined]
[11] macro expansion
@ ~/work/Manifolds.jl/Manifolds.jl/test/manifolds/product_manifold.jl:342 [inlined]
[12] macro expansion
@ /opt/hostedtoolcache/julia/1.10.0-rc3/x64/share/julia/stdlib/v1.10/Test/src/Test.jl:[1577](https://github.com/JuliaManifolds/Manifolds.jl/actions/runs/7331778597/job/19964918540?pr=691#step:6:1580) [inlined]
[13] top-level scope
@ ~/work/Manifolds.jl/Manifolds.jl/test/manifolds/product_manifold.jl:6
This pull request changes the compat entry for the
RecursiveArrayTools
package from2
to2, 3
. This keeps the compat entries for earlier versions.Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.