search

JuliaManifolds / Manifolds.jl

Manifolds.jl provides a library of manifolds aiming for an easy-to-use and fast implementation.
https://juliamanifolds.github.io/Manifolds.jl
MIT License
366 stars 52 forks source link

Fix `var` for `TranslationGroup` #703

Closed mateuszbaran closed 7 months ago

mateuszbaran commented 7 months ago

Reported here: https://github.com/JuliaRobotics/IncrementalInference.jl/issues/1811 .

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (81a43d4) 99.57% compared to head (d550181) 99.58%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #703 +/- ## ======================================= Coverage 99.57% 99.58% ======================================= Files 108 108 Lines 10713 10715 +2 ======================================= + Hits 10668 10670 +2 Misses 45 45 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mateuszbaran commented 7 months ago

Sure, I've generalized it and the line is now covered.

dehann commented 7 months ago

Thanks very much!