search

JuliaManifolds / Manifolds.jl

Manifolds.jl provides a library of manifolds aiming for an easy-to-use and fast implementation.
https://juliamanifolds.github.io/Manifolds.jl
MIT License
366 stars 52 forks source link

Sectional curvature #711

Closed mateuszbaran closed 5 months ago

mateuszbaran commented 5 months ago

Just finishing the work on sectional curvature.

kellertuer commented 5 months ago

Hm, direct dependency is not so nice, but maybe necessary here to finish this in finite time. Really a bit sad that BVP breaks so often

mateuszbaran commented 5 months ago

Yes, I don't like this solution but I hope this is only a temporary measure until they fix the bug. It seems that BVP breaks more often than all our other dependencies combined...

mateuszbaran commented 5 months ago

Speaking of bugs in other dependencies...

ERROR: LoadError: UndefVarError: `pyisnone` not defined
Stacktrace:
  [1] getproperty
    @ ./Base.jl:31 [inlined]
  [2] _py_bbox(obj::PythonCall.Core.Py)
    @ Plots ~/.julia/packages/Plots/a3u1v/src/backends/pythonplot.jl:219
  [3] _update_min_padding!(sp::Plots.Subplot{Plots.PythonPlotBackend})
    @ Plots ~/.julia/packages/Plots/a3u1v/src/backends/pythonplot.jl:1253
mateuszbaran commented 5 months ago

See https://github.com/JuliaPlots/Plots.jl/issues/4905 (the name of user opening that issue :smile:)

mateuszbaran commented 5 months ago

It looks like with two new constraints, CI is passing. I'd suggest merging #710 and #712 first, and this one last, and then release 0.9.15 @kellertuer .

I've also updated the default vector transport method as discussed there: https://github.com/JuliaManifolds/Manopt.jl/discussions/349#discussioncomment-8811114 .

kellertuer commented 5 months ago

Nice, sounds like a good plan to me :)

mateuszbaran commented 5 months ago

Great, then I'll go with it.