search

JuliaManifolds / Manifolds.jl

Manifolds.jl provides a library of manifolds aiming for an easy-to-use and fast implementation.
https://juliamanifolds.github.io/Manifolds.jl
MIT License
366 stars 52 forks source link

Trying to fix FiniteDifferences + SArray failure #729

Closed mateuszbaran closed 2 months ago

mateuszbaran commented 2 months ago

Maybe it will fix the CI failure in #728

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.58%. Comparing base (b0008c0) to head (1fe101b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #729 +/- ## =========================================== + Coverage 42.14% 99.58% +57.43% =========================================== Files 114 114 Lines 11111 11230 +119 =========================================== + Hits 4683 11183 +6500 + Misses 6428 47 -6381 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kellertuer commented 2 months ago

...and why did that work previously? Just curious.

mateuszbaran commented 2 months ago

Either FiniteDifferences.jl were fine with SArray or OrdinaryDiffEq.jl didn't try calling the f function with SArray -- I didn't check which one it is.