JuliaManifolds / ManifoldsBase.jl

Basic interface for manifolds in Julia
https://juliamanifolds.github.io/ManifoldsBase.jl/
MIT License
87 stars 8 forks source link

Default for getting ONB is pushed down in call chain #100

Closed mateuszbaran closed 2 years ago

mateuszbaran commented 2 years ago

I've discovered this while investigating one of coverage failures in Manifolds.jl -- we fall back to the default too early and implementations for specific manifolds are skipped.

codecov[bot] commented 2 years ago

Codecov Report

Merging #100 (b80eba1) into master (0e9ae0f) will decrease coverage by 0.04%. The diff coverage is 100.00%.

:exclamation: Current head b80eba1 differs from pull request most recent head 1236e1f. Consider uploading reports for the commit 1236e1f to get more accurate results

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   99.80%   99.75%   -0.05%     
==========================================
  Files          17       17              
  Lines        2051     2047       -4     
==========================================
- Hits         2047     2042       -5     
- Misses          4        5       +1     
Impacted Files Coverage Δ
src/DefaultManifold.jl 100.00% <100.00%> (ø)
src/bases.jl 100.00% <100.00%> (ø)
src/ManifoldsBase.jl 97.67% <0.00%> (-1.56%) :arrow_down:
src/ValidationManifold.jl 99.48% <0.00%> (-0.52%) :arrow_down:
src/numbers.jl 100.00% <0.00%> (ø)
src/PowerManifold.jl 99.77% <0.00%> (+0.44%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more