from calling ìs_vectortocheck_vector. I just noticed a problem with that. Namely if we have iterated embeddings (General Grassmann is embedded into Generalised Stiefel is embedded into Euclidean) this only checks one level and does not iterate this (since the decorator is only done foris_vector`. What do you think should we do about this? If possible I would like to switch back.
In pur last PR we changed the line
https://github.com/JuliaManifolds/ManifoldsBase.jl/blob/5fa0a5c8b46694cdf8186c3668d40ae91f2ed809/src/decorator_trait.jl#L386
from calling ìs_vector
to
check_vector. I just noticed a problem with that. Namely if we have iterated embeddings (General Grassmann is embedded into Generalised Stiefel is embedded into Euclidean) this only checks one level and does not iterate this (since the decorator is only done for
is_vector`. What do you think should we do about this? If possible I would like to switch back.