search

JuliaManifolds / ManifoldsBase.jl

Basic interface for manifolds in Julia
https://juliamanifolds.github.io/ManifoldsBase.jl/
MIT License
87 stars 8 forks source link

check_vector or is_vector – problem with iterated embeddings #102

Closed kellertuer closed 2 years ago

kellertuer commented 2 years ago

In pur last PR we changed the line

https://github.com/JuliaManifolds/ManifoldsBase.jl/blob/5fa0a5c8b46694cdf8186c3668d40ae91f2ed809/src/decorator_trait.jl#L386

from calling ìs_vectortocheck_vector. I just noticed a problem with that. Namely if we have iterated embeddings (General Grassmann is embedded into Generalised Stiefel is embedded into Euclidean) this only checks one level and does not iterate this (since the decorator is only done foris_vector`. What do you think should we do about this? If possible I would like to switch back.

mateuszbaran commented 2 years ago

I've responded in the PR, I think calling is_vector and catching errors is fine.