codecov[bot]
commented
2 years ago Codecov Report
Merging #106 (ec6448b) into master (fef7a2d) will increase coverage by
0.00%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #106 +/- ##
=======================================
Coverage 99.80% 99.80%
=======================================
Files 17 17
Lines 2074 2086 +12
=======================================
+ Hits 2070 2082 +12
Misses 4 4 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/ManifoldsBase.jl | 99.22% <ø> (ø) |
|
| src/exp_log_geo.jl | 100.00% <100.00%> (ø) |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more
mateuszbaran
A student of mine proposed to maybe also have mutating geodesics. Here is my sketch to these, since it Tok only a few minutes to write these.
But since tests are not 100% working, I would like some feedback whether this is useful, before trying to fix the last few tests with custom point/vector types.
edit: found the bug; when copying the tests to shortest_geodesic I forgot to change one argument. So, this should be done and tested, but whether it is useful and a nice form – let me know.