JuliaManifolds / ManifoldsBase.jl

Basic interface for manifolds in Julia
https://juliamanifolds.github.io/ManifoldsBase.jl/
MIT License
87 stars 8 forks source link

First approach to tackle parametrised types in fallbacks. #110

Closed kellertuer closed 2 years ago

kellertuer commented 2 years ago

Trying to solve #109.

I tried adapting the given There for the vector fallbacks, but since we do not use that anywhere I am not yet sure this is right nor how to use it. Something like

ManifoldsBase.@default_manifold_fallbacks Stiefel{n,k,𝔽} StiefelPoint StiefelTVector n, k, 𝔽 value value

which somehow does not work and with {} it tries to construct a vector, so I am not yet sure what to best do here, but I'm also not much an expert on macros and have not yet understood how the other Twhere would have to be used..

codecov[bot] commented 2 years ago

Codecov Report

Merging #110 (8b3cebb) into master (bd55280) will decrease coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   99.81%   99.76%   -0.05%     
==========================================
  Files          17       17              
  Lines        2112     2115       +3     
==========================================
+ Hits         2108     2110       +2     
- Misses          4        5       +1     
Impacted Files Coverage Ξ”
src/point_vector_fallbacks.jl 100.00% <100.00%> (ΓΈ)
src/PowerManifold.jl 99.16% <0.00%> (-0.21%) :arrow_down:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more