search

JuliaManifolds / ManifoldsBase.jl

Basic interface for manifolds in Julia
https://juliamanifolds.github.io/ManifoldsBase.jl/
MIT License
87 stars 8 forks source link

Add is_point and is_vector to manifold fallbacks #115

Closed kellertuer closed 2 years ago

kellertuer commented 2 years ago

For default types we need to first unwrap the data (fall back to arrays) before we come to the embedding dispatch. this PR solves that issue.

codecov[bot] commented 2 years ago

Codecov Report

Merging #115 (32c99d0) into master (3c4530e) will decrease coverage by 0.18%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
- Coverage   99.81%   99.62%   -0.19%     
==========================================
  Files          17       17              
  Lines        2115     2119       +4     
==========================================
  Hits         2111     2111              
- Misses          4        8       +4
Impacted Files Coverage Δ
src/point_vector_fallbacks.jl 98.17% <100.00%> (-1.83%) :arrow_down:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

kellertuer commented 2 years ago

Nevermind. Properly defining embed for the types is the even better way to go.