Closed mateuszbaran closed 2 years ago
Ah, StaticArraysCore
is not available for Julia 1.0. So now I'm not sure where to put
function allocate(::PowerManifoldNestedReplacing, x::AbstractArray{<:SArray})
return similar(x)
end
Isn‘t Nested only properly implemented over on Manifolds? Well we could put it somewhere there anyways.
Some parts of nested work with plain base but we extend it in Manifolds.jl anyway. I think I'll do just that.
Merging #116 (1bfa80d) into master (3c4530e) will increase coverage by
0.00%
. The diff coverage is100.00%
.:exclamation: Current head 1bfa80d differs from pull request most recent head e048288. Consider uploading reports for the commit e048288 to get more accurate results
@@ Coverage Diff @@
## master #116 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 17 17
Lines 2115 2117 +2
=======================================
+ Hits 2111 2113 +2
Misses 4 4
Impacted Files | Coverage Δ | |
---|---|---|
src/EmbeddedManifold.jl | 100.00% <100.00%> (ø) |
|
src/ManifoldsBase.jl | 97.81% <100.00%> (-1.42%) |
:arrow_down: |
src/PowerManifold.jl | 100.00% <100.00%> (+0.62%) |
:arrow_up: |
src/decorator_trait.jl | 100.00% <100.00%> (ø) |
|
src/ValidationManifold.jl | 99.48% <0.00%> (-0.52%) |
:arrow_down: |
src/numbers.jl | 100.00% <0.00%> (ø) |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more
Another point from https://github.com/JuliaManifolds/Manifolds.jl/issues/497 .