search

JuliaManifolds / ManifoldsBase.jl

Basic interface for manifolds in Julia
https://juliamanifolds.github.io/ManifoldsBase.jl/
MIT License
87 stars 8 forks source link

New customization points for `Identity` specialization #117

Closed mateuszbaran closed 2 years ago

mateuszbaran commented 2 years ago

Required to more generically solve point 4 of https://github.com/JuliaManifolds/Manifolds.jl/issues/497 in Manifolds.jl.

codecov[bot] commented 2 years ago

Codecov Report

Merging #117 (12084e8) into master (0c81e38) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #117   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          17       17           
  Lines        2123     2127    +4     
=======================================
+ Hits         2119     2123    +4     
  Misses          4        4
Impacted Files Coverage Δ
src/ManifoldsBase.jl 99.28% <100.00%> (+0.01%) :arrow_up:
src/PowerManifold.jl 99.37% <100.00%> (+<0.01%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

mateuszbaran commented 2 years ago

@kellertuer could you review this? It would enable some improvements in Manifolds.jl regarding usage of Identity as argument to different functions, see point 4 of https://github.com/JuliaManifolds/Manifolds.jl/issues/497 .