JuliaManifolds / ManifoldsBase.jl

Basic interface for manifolds in Julia
https://juliamanifolds.github.io/ManifoldsBase.jl/
MIT License
87 stars 8 forks source link

Faster `get_basis_orthonormal` #118

Closed mateuszbaran closed 2 years ago

mateuszbaran commented 2 years ago

This is much faster get_basis_orthonormal (constants weren't properly propagated). Also some inlines, at least one of them was needed but other should be harmless anyway, or maybe even helpful in some rare cases..

codecov[bot] commented 2 years ago

Codecov Report

Merging #118 (11a1d64) into master (1f022f9) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          17       17           
  Lines        2127     2129    +2     
=======================================
+ Hits         2123     2125    +2     
  Misses          4        4           
Impacted Files Coverage Δ
src/bases.jl 100.00% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more