search

JuliaManifolds / ManifoldsBase.jl

Basic interface for manifolds in Julia
https://juliamanifolds.github.io/ManifoldsBase.jl/
MIT License
87 stars 8 forks source link

Inverse retraction based distance approximation #119

Closed mateuszbaran closed 2 years ago

mateuszbaran commented 2 years ago

Required to complete https://github.com/JuliaManifolds/Manopt.jl/pull/138 .

codecov[bot] commented 2 years ago

Codecov Report

Merging #119 (0c7667e) into master (e509370) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          17       17           
  Lines        2129     2132    +3     
=======================================
+ Hits         2125     2128    +3     
  Misses          4        4
Impacted Files Coverage Δ
src/ManifoldsBase.jl 99.30% <100.00%> (+0.01%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

mateuszbaran commented 2 years ago

What I think is nice about this is that we don't have to explicitly compute the inverse retraction if a manifold provides a faster implementation for a particular case.