search

JuliaManifolds / ManifoldsBase.jl

Basic interface for manifolds in Julia
https://juliamanifolds.github.io/ManifoldsBase.jl/
MIT License
87 stars 8 forks source link

Better default for get_basis coordinate eltype #120

Closed mateuszbaran closed 2 years ago

mateuszbaran commented 2 years ago

Just a small enhancement to make it possible to use this get_basis for quaternionic unitary matrices (see https://github.com/JuliaManifolds/Manifolds.jl/pull/511).

codecov[bot] commented 2 years ago

Codecov Report

Merging #120 (dbab33a) into master (44e2da8) will decrease coverage by 0.00%. The diff coverage is 100.00%.

:exclamation: Current head dbab33a differs from pull request most recent head c008500. Consider uploading reports for the commit c008500 to get more accurate results

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
- Coverage   99.81%   99.81%   -0.01%     
==========================================
  Files          17       17              
  Lines        2132     2130       -2     
==========================================
- Hits         2128     2126       -2     
  Misses          4        4
Impacted Files Coverage Δ
src/bases.jl 100.00% <100.00%> (ø)
src/ManifoldsBase.jl 97.90% <0.00%> (-1.40%) :arrow_down:
src/ValidationManifold.jl 99.48% <0.00%> (-0.52%) :arrow_down:
src/numbers.jl 100.00% <0.00%> (ø)
src/PowerManifold.jl 100.00% <0.00%> (+0.62%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

mateuszbaran commented 2 years ago

I think this is ready to be merged now :slightly_smiling_face: