search

JuliaManifolds / ManifoldsBase.jl

Basic interface for manifolds in Julia
https://juliamanifolds.github.io/ManifoldsBase.jl/
MIT License
87 stars 8 forks source link

allocate_result IsExplicitDecorator #123

Closed mateuszbaran closed 2 years ago

mateuszbaran commented 2 years ago

This is a small thing required to finish my changes to https://github.com/JuliaManifolds/Manifolds.jl/pull/515 .

codecov[bot] commented 2 years ago

Codecov Report

Merging #123 (60db3e0) into master (dad56f8) will decrease coverage by 0.04%. The diff coverage is 100.00%.

:exclamation: Current head 60db3e0 differs from pull request most recent head c1f30fa. Consider uploading reports for the commit c1f30fa to get more accurate results

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
- Coverage   99.85%   99.81%   -0.05%     
==========================================
  Files          17       17              
  Lines        2140     2137       -3     
==========================================
- Hits         2137     2133       -4     
- Misses          3        4       +1
Impacted Files Coverage Δ
src/decorator_trait.jl 100.00% <100.00%> (ø)
src/ManifoldsBase.jl 97.94% <0.00%> (-1.37%) :arrow_down:
src/ValidationManifold.jl 99.48% <0.00%> (-0.52%) :arrow_down:
src/numbers.jl 100.00% <0.00%> (ø)
src/PowerManifold.jl 100.00% <0.00%> (+0.41%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

kellertuer commented 2 years ago

Oh, nicely spotted!

Can you check this with a test?

mateuszbaran commented 2 years ago

Sure, this test should do it.