search

JuliaManifolds / ManifoldsBase.jl

Basic interface for manifolds in Julia
https://juliamanifolds.github.io/ManifoldsBase.jl/
MIT License
87 stars 8 forks source link

Change function signature of `is_` functions to be consistent with `isapprox`. #135

Closed kellertuer closed 10 months ago

kellertuer commented 1 year ago

To be consistent with the newly planned error mode, these two positional arguments of is_point (for the first) and is_vector these two should become keyword arguments. This should also be done for the internal check_ functions also for consistency with the isapprox and check_approx functions, see also discussions in #134.

kellertuer commented 1 year ago

...somehow we did not do this in 0.14.0 ;)

mateuszbaran commented 1 year ago

I forgot to check :/.