JuliaManifolds / ManifoldsBase.jl

Basic interface for manifolds in Julia
https://juliamanifolds.github.io/ManifoldsBase.jl/
MIT License
87 stars 8 forks source link

Don't inline `invoke` in a generic fallback. #138

Closed mateuszbaran closed 1 year ago

mateuszbaran commented 1 year ago

Workaround for https://discourse.julialang.org/t/extremely-slow-invoke-when-inlined/90665 .

mateuszbaran commented 1 year ago

I will tag 0.13.26 after merging this.

mateuszbaran commented 1 year ago

Ref. https://github.com/JuliaLang/julia/pull/47671

codecov[bot] commented 1 year ago

Codecov Report

Merging #138 (e993304) into master (fa5226f) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files          18       18           
  Lines        2391     2391           
=======================================
  Hits         2385     2385           
  Misses          6        6           
Impacted Files Coverage Δ
src/ValidationManifold.jl 100.00% <ø> (ø)
src/nested_trait.jl 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

kellertuer commented 1 year ago

Nice! You even managed to get an update to Julia with that. Super!

mateuszbaran commented 1 year ago

Yes, it's cool that the issue may be fixed directly in Julia.

mateuszbaran commented 1 year ago

CI keeps failing on Julia 1.0/macOS without a clear error message :confused: .

kellertuer commented 1 year ago

How general where Varargs possible in Julia 1.0?

mateuszbaran commented 1 year ago

Since the code works on Ubuntu and the Vararg change passed CI earlier, I'd say that it's certainly not the issue here.

kellertuer commented 1 year ago

Oh, yes, I did not notice that; hm, to me the message looks a little bit like Pkg not being able to get the package, at least on windows I had a similar message once that vanished after a while.