JuliaManifolds / ManifoldsBase.jl

Basic interface for manifolds in Julia
https://juliamanifolds.github.io/ManifoldsBase.jl/
MIT License
87 stars 8 forks source link

Check for having to call `get_basis` on a basis #139

Closed mateuszbaran closed 1 year ago

mateuszbaran commented 1 year ago

This is the thing I wrote about here: https://github.com/JuliaManifolds/Manopt.jl/pull/167#issue-1453906466 .

codecov[bot] commented 1 year ago

Codecov Report

Merging #139 (2104be4) into master (c487559) will decrease coverage by 0.12%. The diff coverage is 100.00%.

:exclamation: Current head 2104be4 differs from pull request most recent head 941a92f. Consider uploading reports for the commit 941a92f to get more accurate results

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
- Coverage   99.79%   99.66%   -0.13%     
==========================================
  Files          18       18              
  Lines        2390     2392       +2     
==========================================
- Hits         2385     2384       -1     
- Misses          5        8       +3     
Impacted Files Coverage Δ
src/bases.jl 100.00% <100.00%> (ø)
src/ManifoldsBase.jl 98.58% <0.00%> (-0.95%) :arrow_down:
src/decorator_trait.jl 99.31% <0.00%> (-0.69%) :arrow_down:
src/numbers.jl 100.00% <0.00%> (ø)
src/PowerManifold.jl 99.59% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

kellertuer commented 1 year ago

Will that already be used here in Base somewhere or is it just useful over on the LM-Alg?

mateuszbaran commented 1 year ago

This can be useful for any algorithm that needs to call get_vector or get_coordinates on arbitrary bases. We just didn't really care before because usually DefaultOrthonormalBasis works fine.

kellertuer commented 1 year ago

Cool. I was just wondering whether it might even be useful somewhere in here already?

mateuszbaran commented 1 year ago

Maybe it could already be useful for something, I haven't given it much thought.