Were we not careful enough with ManifoldsBase 0.14?

JuliaManifolds / ManifoldsBase.jl

Basic interface for manifolds in Julia

https://juliamanifolds.github.io/ManifoldsBase.jl/

MIT License

83 stars 8 forks source link

Were we not careful enough with ManifoldsBase 0.14? #147

Closed kellertuer closed 1 year ago

kellertuer commented 1 year ago

I just noticed that since ManifoldsBase 0.14 we have quite a few inexact errors with NaNs?

see

https://github.com/JuliaManifolds/ManifoldsBase.jl/actions/runs/4187041219/jobs/7256354396#step:5:354

kellertuer commented 1 year ago

...or are those expected infos? Then I would switch them to test_logs in my next PR.

mateuszbaran commented 1 year ago

I've added those tests on purpose, maybe it should be done a bit differently -- I didn't know about test_logs.

kellertuer commented 1 year ago

Already fixed it in the linked new PR :)

I feel if there is info-things printed it should be for a reason and Error-Infos might be misleading (for example for me sometimes) so now they are in log-checks :)