JuliaManifolds / ManifoldsBase.jl

Basic interface for manifolds in Julia
https://juliamanifolds.github.io/ManifoldsBase.jl/
MIT License
83 stars 8 forks source link

Introduce change_representer already in ManifoldsBase #148

Closed kellertuer closed 1 year ago

kellertuer commented 1 year ago

We still might need tests for change_representer.

codecov[bot] commented 1 year ago

Codecov Report

Merging #148 (0ba73a5) into master (21ccb40) will decrease coverage by 0.08%. The diff coverage is 100.00%.

:exclamation: Current head 0ba73a5 differs from pull request most recent head b7b69a9. Consider uploading reports for the commit b7b69a9 to get more accurate results

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
- Coverage   99.92%   99.84%   -0.08%     
==========================================
  Files          19       19              
  Lines        2522     2529       +7     
==========================================
+ Hits         2520     2525       +5     
- Misses          2        4       +2     
Impacted Files Coverage Δ
src/ManifoldsBase.jl 98.34% <ø> (-1.25%) :arrow_down:
src/decorator_trait.jl 100.00% <ø> (ø)
src/DefaultManifold.jl 100.00% <100.00%> (ø)
src/metric.jl 100.00% <100.00%> (ø)
src/PowerManifold.jl 100.00% <0.00%> (+0.18%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

mateuszbaran commented 1 year ago

I think this is a good idea.