JuliaManifolds / ManifoldsBase.jl

Basic interface for manifolds in Julia
https://juliamanifolds.github.io/ManifoldsBase.jl/
MIT License
83 stars 8 forks source link

Make dispatching on `TypeParameter` more flexible #162

Closed mateuszbaran closed 11 months ago

mateuszbaran commented 11 months ago

Slightly reworks #160 to make it possible to dispatch on the number of type parameters and their values. E.g.

get_vector_orthonormal(::Euclidean{TypeParameter{Tuple{N}},ℝ}, ::Any, c, ::RealNumbers) where {N}

Sadly, I can't make this dispatching nicer.

codecov[bot] commented 11 months ago

Codecov Report

Merging #162 (7532b75) into master (c197b7c) will decrease coverage by 0.12%. The diff coverage is 100.00%.

:exclamation: Current head 7532b75 differs from pull request most recent head 914ec45. Consider uploading reports for the commit 914ec45 to get more accurate results

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
- Coverage   99.96%   99.84%   -0.12%     
==========================================
  Files          20       20              
  Lines        2553     2553              
==========================================
- Hits         2552     2549       -3     
- Misses          1        4       +3     
Files Changed Coverage Δ
src/maintypes.jl 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more