JuliaManifolds / ManifoldsBase.jl

Basic interface for manifolds in Julia
https://juliamanifolds.github.io/ManifoldsBase.jl/
MIT License
83 stars 8 forks source link

Introduce the Weingarten map. #163

Closed kellertuer closed 11 months ago

kellertuer commented 11 months ago

We could check whether

codecov[bot] commented 11 months ago

Codecov Report

Merging #163 (c245e55) into master (8a4f3b1) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #163   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files          20       20           
  Lines        2553     2558    +5     
=======================================
+ Hits         2552     2557    +5     
  Misses          1        1           
Files Changed Coverage Δ
src/DefaultManifold.jl 100.00% <100.00%> (ø)
src/ManifoldsBase.jl 99.60% <100.00%> (+<0.01%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

kellertuer commented 11 months ago

I am not sure why the report above says 3 lines are missing, which are from a Julia version pre 1.1, while the tests all pass. But besides that this should be good to go (even with updated News.md).

mateuszbaran commented 11 months ago

There are three lines that keep being not counted correctly so I'd ignore it.

Have you actually committed the updates to News.md? I don't see them.

kellertuer commented 11 months ago

Of course I committed them! But you are right, I should probably also have pushed them 😴