search

JuliaManifolds / ManifoldsBase.jl

Basic interface for manifolds in Julia
https://juliamanifolds.github.io/ManifoldsBase.jl/
MIT License
83 stars 8 forks source link

Fix checks on TpM #171

Closed kellertuer closed 8 months ago

kellertuer commented 8 months ago

I noticed that is_point and is_vector were a bit too vague (accepting too much as correct points/vectors).

This PR fixes that by passing points/vectors to the vector check.

codecov[bot] commented 8 months ago

Codecov Report

Merging #171 (5f023cc) into master (3fbf075) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #171   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files          26       26           
  Lines        3065     3072    +7     
=======================================
+ Hits         3064     3071    +7     
  Misses          1        1
Files Coverage Δ
src/TangentSpace.jl 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more