JuliaManifolds / ManifoldsBase.jl

Basic interface for manifolds in Julia
https://juliamanifolds.github.io/ManifoldsBase.jl/
MIT License
87 stars 8 forks source link

Fix retarction with t on power manifold #175

Closed kellertuer closed 10 months ago

kellertuer commented 10 months ago

In our memory-allocate-first approach now for retractions and that one can use retractions directly on Power manifold (and they are defined here) we missed to pass on retract(M, p, X, t, m) (and its corresponding retract!. This resolves https://github.com/JuliaManifolds/Manopt.jl/issues/330.

I still have to check test coverage, besides that this is good to go.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (81d2d93) 99.96% compared to head (e13a52d) 99.96%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #175 +/- ## ======================================= Coverage 99.96% 99.96% ======================================= Files 26 26 Lines 3075 3087 +12 ======================================= + Hits 3074 3086 +12 Misses 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.