search

JuliaManifolds / ManifoldsBase.jl

Basic interface for manifolds in Julia
https://juliamanifolds.github.io/ManifoldsBase.jl/
MIT License
83 stars 8 forks source link

Fix number_eltype(Vector{Vector{Float64}}) #179

Closed mateuszbaran closed 7 months ago

mateuszbaran commented 7 months ago

See https://github.com/JuliaManifolds/Manifolds.jl/pull/692#discussion_r1427781125 .

kellertuer commented 7 months ago

Ah we could also have done this on the other branch / PR. This looks good to me – should we still combine it with the other PRs into one new version?

mateuszbaran commented 7 months ago

Sure, we can merge everything into one release.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (10d930f) 99.96% compared to head (288fa9d) 99.96%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #179 +/- ## ======================================= Coverage 99.96% 99.96% ======================================= Files 26 26 Lines 3087 3091 +4 ======================================= + Hits 3086 3090 +4 Misses 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.