JuliaManifolds / ManifoldsBase.jl

Basic interface for manifolds in Julia
https://juliamanifolds.github.io/ManifoldsBase.jl/
MIT License
83 stars 8 forks source link

Fix info/warn print of checks #182

Closed kellertuer closed 6 months ago

kellertuer commented 6 months ago

As we noticed in Manifolds.jl/#702 sometimes errors printed on info/warn errored themselves

This was due to a “hardcoded” print using e.val and e.msg which not all errors might have.

This PR fixes that by using showerror instead, which errors should implement anyways.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (65780dc) 99.96% compared to head (5ded609) 99.96%. Report is 1 commits behind head on master.

:exclamation: Current head 5ded609 differs from pull request most recent head 034c08c. Consider uploading reports for the commit 034c08c to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #182 +/- ## ======================================= Coverage 99.96% 99.96% ======================================= Files 27 27 Lines 3093 3107 +14 ======================================= + Hits 3092 3106 +14 Misses 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.