search

JuliaManifolds / ManifoldsBase.jl

Basic interface for manifolds in Julia
https://juliamanifolds.github.io/ManifoldsBase.jl/
MIT License
87 stars 8 forks source link

Add helpful message when `ProductManifold` is used without RAT.jl #201

Closed mateuszbaran closed 2 weeks ago

mateuszbaran commented 2 weeks ago

I had to change representation_size for ProductManifold for this but I think it doesn't make that much sense anyway.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.90%. Comparing base (8469ef9) to head (2753277). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #201 +/- ## ======================================= Coverage 99.90% 99.90% ======================================= Files 31 31 Lines 3294 3300 +6 ======================================= + Hits 3291 3297 +6 Misses 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kellertuer commented 2 weeks ago

One could consider this breaking since it introduces an error in some cases; but I think instead of nothing being more careful with that is more like improve the user experience, so that is fine with me even in a nonbreaking sense.

mateuszbaran commented 2 weeks ago

Yes, it's technically breaking but it's a part that no one should rely on.