search

JuliaManifolds / ManifoldsBase.jl

Basic interface for manifolds in Julia
https://juliamanifolds.github.io/ManifoldsBase.jl/
MIT License
87 stars 8 forks source link

Introduce two new vector transports #57

Closed kellertuer closed 3 years ago

kellertuer commented 3 years ago

Namely DifferentiatedRetractionVectorTransport and ScaledVectorTransport.

codecov[bot] commented 3 years ago

Codecov Report

Merging #57 (3150a52) into master (a57e0fa) will increase coverage by 0.10%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   99.50%   99.61%   +0.10%     
==========================================
  Files          10       10              
  Lines        1017     1298     +281     
==========================================
+ Hits         1012     1293     +281     
  Misses          5        5
Impacted Files Coverage Δ
src/DecoratorManifold.jl 100.00% <ø> (ø)
src/ManifoldsBase.jl 99.39% <100.00%> (+0.18%) :arrow_up:
src/ValidationManifold.jl 100.00% <100.00%> (ø)
src/vector_transport.jl 100.00% <100.00%> (ø)
src/bases.jl 100.00% <0.00%> (ø)
src/errors.jl 100.00% <0.00%> (ø)
src/numbers.jl 100.00% <0.00%> (ø)
src/DefaultManifold.jl 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a57e0fa...3150a52. Read the comment docs.

kellertuer commented 3 years ago

Test coverage is as good as before, the - 3 lines are due to an optimization that spared a few lines.

kellertuer commented 3 years ago

Yes they are marked correctly as far as I can see; so I will merge. Thanks for the help!