search

JuliaManifolds / ManifoldsBase.jl

Basic interface for manifolds in Julia
https://juliamanifolds.github.io/ManifoldsBase.jl/
MIT License
88 stars 8 forks source link

Make distance dispatch to parent for embedded manifold #64

Closed sethaxen closed 3 years ago

sethaxen commented 3 years ago

Fixes part of https://github.com/JuliaManifolds/Manifolds.jl/issues/338.

codecov[bot] commented 3 years ago

Codecov Report

Merging #64 (4e9b03f) into master (7edbfc5) will increase coverage by 0.07%. The diff coverage is 100.00%.

:exclamation: Current head 4e9b03f differs from pull request most recent head 1ee412f. Consider uploading reports for the commit 1ee412f to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   99.61%   99.69%   +0.07%     
==========================================
  Files          10       10              
  Lines        1298     1302       +4     
==========================================
+ Hits         1293     1298       +5     
+ Misses          5        4       -1
Impacted Files Coverage Δ
src/EmbeddedManifold.jl 99.31% <100.00%> (+0.01%) :arrow_up:
src/bases.jl 100.00% <0.00%> (ø)
src/PowerManifold.jl 99.12% <0.00%> (+0.43%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7edbfc5...1ee412f. Read the comment docs.