Closed kellertuer closed 3 years ago
Merging #66 (429672f) into master (694b196) will increase coverage by
0.75%
. The diff coverage is100.00%
.:exclamation: Current head 429672f differs from pull request most recent head 1fd5acc. Consider uploading reports for the commit 1fd5acc to get more accurate results
@@ Coverage Diff @@
## master #66 +/- ##
==========================================
+ Coverage 98.93% 99.69% +0.75%
==========================================
Files 10 10
Lines 1320 1320
==========================================
+ Hits 1306 1316 +10
+ Misses 14 4 -10
Impacted Files | Coverage Δ | |
---|---|---|
src/PowerManifold.jl | 99.15% <100.00%> (+4.20%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 694b196...1fd5acc. Read the comment docs.
Since for the last PR codecov got confused, here's the missing coverage.
There should be 4 lines remaining (and one ambiguity with
getindex
and static arrays from 1.6 onwards), where the two linesmid_point!
also on Julia 1.0, so I am not sure why we miss https://codecov.io/gh/JuliaManifolds/ManifoldsBase.jl/src/master/src/ManifoldsBase.jl#L655CachedBasis
, it seems that either still dispatches to the function above or is an error of codecov