codecov[bot]
commented
2 years ago Codecov Report
Merging #98 (77485ea) into master (8097c01) will increase coverage by
0.00%. The diff coverage is100.00%.:exclamation: Current head 77485ea differs from pull request most recent head fed9275. Consider uploading reports for the commit fed9275 to get more accurate results
@@ Coverage Diff @@
## master #98 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 17 17
Lines 2043 2044 +1
=======================================
+ Hits 2038 2039 +1
Misses 5 5 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/bases.jl | 100.00% <100.00%> (ø) |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more
I've been slightly annoyed by diagonalizing basis on tangent bundle not being printed correctly (it's incorrect anyway but it's a different issue) and I think it would make sense to stop relying on being able to do
T()here. This is one way to fix the issue, probably a better one would be storing object of typeTinCachedBasisitself -- I can change that if you prefer it @kellertuer .