search

JuliaManifolds / Manopt.jl

🏔️Manopt. jl – Optimization on Manifolds in Julia
http://manoptjl.org
Other
321 stars 40 forks source link

a few typos in comments #276

Closed flgoyens closed 1 year ago

kellertuer commented 1 year ago

Thanks for noticing the fixes and great that you are using Manopt.jl :)

Your fix of the stopping criterion typo broke one test, where we use the reason string to check that the right stopping criterion was met. Could you check in the file test/solvers/test_truncated_cg.jl line 21 and fix the typo here as well?

flgoyens commented 1 year ago

Hi @kellertuer !

I was indeed surprised to break something. Thanks for pointing me towards the fix, I'll get to that :)

Best Florentin

kellertuer commented 1 year ago

Well, we test also the show methods you changed; but sure we could have also spotted the typo when writing the test ;)

kellertuer commented 1 year ago

Thanks for the fix; now this can be merged and will be part of the next version. Thanks for your PR :)