search

JuliaManifolds / Manopt.jl

🏔️Manopt. jl – Optimization on Manifolds in Julia
http://manoptjl.org
Other
314 stars 40 forks source link

Bump dependencies. #309

Closed kellertuer closed 10 months ago

kellertuer commented 10 months ago

To ManifoldsBase.jl 0.15 and Manifolds.jl 0.9

codecov[bot] commented 10 months ago

Codecov Report

Merging #309 (b83e291) into master (d6acf64) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #309   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files          77       76    -1     
  Lines        7090     7090           
=======================================
  Hits         7072     7072           
  Misses         18       18
Files Coverage Δ
ext/ManoptManifoldsExt/ManoptManifoldsExt.jl 100.00% <ø> (ø)
src/Manopt.jl 87.50% <ø> (ø)
src/data/artificialDataFunctions.jl 100.00% <ø> (ø)
src/solvers/adaptive_regularization_with_cubics.jl 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

kellertuer commented 10 months ago

Hm, this might be more complicated than I thought, since RecursiveArrays are a dependency of Manifolds but only a weak dependency of ManifoldsBAse, so the alternating gradient can actually not be moved out I think – and if so only into another weak dependency with RecursiveArrays since I need the ArrayPartition?

But I also get error messages slightly longer than Thomas Mann novels when anything in an Extension fails, so those are super hard to read.

mateuszbaran commented 10 months ago

Yes, right, you can't just move the methods that require RecursiveArrayTools to Manopt.jl

mateuszbaran commented 10 months ago

I think we could also add changelog to docs like in Manifolds.jl.

kellertuer commented 10 months ago

Yes, I can do that tomorrow morning.