Unify provided Objectives

JuliaManifolds / Manopt.jl

🏔️Manopt. jl – Optimization on Manifolds in Julia

http://manoptjl.org

Other

314 stars 40 forks source link

Unify provided Objectives #312

Closed kellertuer closed 10 months ago

kellertuer commented 10 months ago

Currently

FrankWolfe
Augmented Lagrangian
ExactPenaltyMethod
DifferenceofConvex

Have sub objectives that are build by using a separate cost and gradient struct. This should be unified to just implementing one objective to avoid duplication in code (and possibly unnecessary duplication of memory). This is currently already fixed for the most recent TR subsolver in #294.

These are internal helpers, so this change might be considered non-breaking still.

kellertuer commented 10 months ago

They are better in their current form indeed, since both forms have their advantages in the defaults.