search

JuliaManifolds / Manopt.jl

🏔️Manopt. jl – Optimization on Manifolds in Julia
http://manoptjl.org
Other
314 stars 40 forks source link

Minor changes to Readme.md #315

Closed odow closed 10 months ago

odow commented 10 months ago

x-ref https://github.com/jump-dev/JuMP.jl/pull/3568

codecov[bot] commented 10 months ago

Codecov Report

Merging #315 (2969182) into master (ed8fcef) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #315   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files          79       79           
  Lines        7353     7353           
=======================================
  Hits         7334     7334           
  Misses         19       19

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

kellertuer commented 10 months ago

You can ignore the changelog error failing here, that is just if we release a new version with a PR the changelog should have an entry. I will add this to another version anyways. You can still add a small (unreleased) entry with a change of the readme as a comment if you want.

kellertuer commented 10 months ago

A : works as well, sure – do you need this registered or is it enough to have this on master/main?

odow commented 10 months ago

It's enough to just have this on main. I can use a commit hash as the reference.

kellertuer commented 10 months ago

Great. Then we can merge this already and it will be part of the next (but a bit later) release.