search

JuliaManifolds / Manopt.jl

🏔️Manopt. jl – Optimization on Manifolds in Julia
http://manoptjl.org
Other
314 stars 40 forks source link

Move Examples. #331

Closed kellertuer closed 9 months ago

kellertuer commented 9 months ago

This PR moves functions that formerly were used in examples to ManoptExamples.jl to reintroduce these old examples over there as well.

While formally this might be considered breaking, I would assume that these functions were actually unused since we abandoned the old examples a year ago when releasing Manopt 0.4. Still all removed functions will be carefully documented in the changelog and the test suite cases / files will also move over.

This resolves one of the points in #297.

This PR is accompanied by the corresponding PRs in ManifoldDiff(https://github.com/JuliaManifolds/ManifoldDiff.jl/pull/37) and ManoptExamples.jl (https://github.com/JuliaManifolds/ManoptExamples.jl/pull/12).

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c8e9079) 99.74% compared to head (c2cc41c) 99.65%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #331 +/- ## ========================================== - Coverage 99.74% 99.65% -0.09% ========================================== Files 79 69 -10 Lines 7353 6337 -1016 ========================================== - Hits 7334 6315 -1019 - Misses 19 22 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kellertuer commented 9 months ago

The reduction in global code coverage is unavoidable, since we reduced the code base but did not cover any of the 19 not yet covered lines. Besides this remark all is working and ready-to-merge.