search

JuliaManifolds / Manopt.jl

🏔️Manopt. jl – Optimization on Manifolds in Julia
http://manoptjl.org
Other
314 stars 40 forks source link

Implementation of two bundle methods #357

Closed hajg-ijk closed 6 months ago

hajg-ijk commented 6 months ago

Implement the convex bundle method and the proximal bundle method.

kellertuer commented 6 months ago

@mateuszbaran do you see why codecov does not want to commit the code coverage? We have a repository token, but it seems to not be used here by now.

mateuszbaran commented 6 months ago

@mateuszbaran do you see why codecov does not want to commit the code coverage? We have a repository token, but it seems to not be used here by now.

I've looked at it but I'm not sure, let's see if your attempt at fixing it is successful.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 99.70588% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 99.58%. Comparing base (8851619) to head (520a821). Report is 5 commits behind head on master.

Files Patch % Lines
src/Manopt.jl 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #357 +/- ## ========================================== + Coverage 99.45% 99.58% +0.13% ========================================== Files 69 73 +4 Lines 6418 6801 +383 ========================================== + Hits 6383 6773 +390 + Misses 35 28 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kellertuer commented 6 months ago

Ah I had to update the CI to explicitly include the token now it works again. Will do that again with the other repositories when we have new PRs. It is something that changed to v4 of the codecov action.

kellertuer commented 6 months ago

besides three small cases

the main thing to implement tests for still are the increase warnings. Maybe by setting up a debug state, triggering debug once, modifying $\xi$ manually and triggering debug again and check for a warning appearing. Yes 1.6 currently even does run into a warning for CBM, but the cases should be tested thoroughly anyways.

So I think we are on a relatively good way by now. For the first two I do not have much of an idea how to trigger these. I could work on the rest (also the points from above) tomorrow or Tuesday evening.

kellertuer commented 6 months ago

We do have code coverage, all docs checked, code unified to rest of Manopt – this is good to go to be merged tomorrow.