search

JuliaManifolds / Manopt.jl

🏔️Manopt. jl – Optimization on Manifolds in Julia
http://manoptjl.org
Other
314 stars 40 forks source link

Change PSO SC to a more efficient way of computing. #369

Closed kellertuer closed 5 months ago

kellertuer commented 5 months ago

I thought a bit about #347. The velocities are actually equivalent to the change (the same if the steps are computed with exp). So this PR changes the stopping criterion of SC to this – a bit nicer – form.

Still to check

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.73%. Comparing base (42d737e) to head (1a4dcd9).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #369 +/- ## ======================================= Coverage 99.73% 99.73% ======================================= Files 73 73 Lines 6819 6839 +20 ======================================= + Hits 6801 6821 +20 Misses 18 18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kellertuer commented 5 months ago

Will merge this but only register it together with #370 once that is also merged