JuliaManifolds / Manopt.jl

🏔️Manopt. jl – Optimization on Manifolds in Julia
http://manoptjl.org
Other
314 stars 40 forks source link

Update `StopWhenAny` constructor for `Vector` #376

Closed Vaibhavdixit02 closed 4 months ago

Vaibhavdixit02 commented 4 months ago

The element type should be subtype of StoppingCriterion

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.76%. Comparing base (7f8d7c6) to head (1b211bf).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #376 +/- ## ========================================== + Coverage 99.74% 99.76% +0.01% ========================================== Files 74 74 Lines 7167 7167 ========================================== + Hits 7149 7150 +1 + Misses 18 17 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kellertuer commented 4 months ago

Ah, well-spotted; it even seems we usually always used the constructor in the line after that.

Could you

Thanks for opening this :)