JuliaManifolds / Manopt.jl

🏔️Manopt. jl – Optimization on Manifolds in Julia
http://manoptjl.org
Other
314 stars 40 forks source link

Fix Initial condition on Lanczos #391

Closed kellertuer closed 2 months ago

kellertuer commented 2 months ago

If you start Lacnzos directly in a mnimizer, the first closed form solution yields NaNs. This is now fixed by checking this in the first order condition (which also does not make sense when we are exactly at a minimiser).

This fixes #390.

🛣️ Roadmap

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.76%. Comparing base (e97d0c0) to head (bcc0ec6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #391 +/- ## ======================================= Coverage 99.76% 99.76% ======================================= Files 71 71 Lines 7221 7224 +3 ======================================= + Hits 7204 7207 +3 Misses 17 17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.