JuliaManifolds / Manopt.jl

🏔️Manopt. jl – Optimization on Manifolds in Julia
http://manoptjl.org
Other
314 stars 40 forks source link

Bundle method(s) patch #396

Closed hajg-ijk closed 2 months ago

hajg-ijk commented 2 months ago

This patch removes functions estimate_sectional_curvature, ζ_1, ζ_2, close_point from convex_bundle_method as they are no longer used. Furthermore, it removes some unused fields and arguments such as k_size, p_estimate, ϱ, α, from ConvexBundleMethodState in favor of jut k_max. Lastly, the parameter R in ProximalBundleMethodState has been placed in fifth position and the initialization of proximal_bundle_method has been fixed.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.77%. Comparing base (befce29) to head (d1748b4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #396 +/- ## ========================================== - Coverage 99.78% 99.77% -0.02% ========================================== Files 72 72 Lines 7586 7574 -12 ========================================== - Hits 7570 7557 -13 - Misses 16 17 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.