search

JuliaManifolds / Manopt.jl

🏔️Manopt. jl – Optimization on Manifolds in Julia
http://manoptjl.org
Other
321 stars 40 forks source link

max_stepsize improvements #402

Closed mateuszbaran closed 3 months ago

mateuszbaran commented 3 months ago

I've been debugging some issues with optimization on Hyperrectangle and noticed it lacks max_stepsize. Also, WolfePowellLinesearch by default tries calling max_stepsize with an invalid point. If it tries to get the global maximum stepsize, it should not provide the point, and if it wants local maximum stepsize (which would make some sense), it should call max_stepsize before each search separately.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.77%. Comparing base (4a52a82) to head (4233ba7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #402 +/- ## ======================================= Coverage 99.77% 99.77% ======================================= Files 72 72 Lines 7574 7592 +18 ======================================= + Hits 7557 7575 +18 Misses 17 17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mateuszbaran commented 3 months ago

Sure, I will update the date in changelog.