JuliaMath / AbstractFFTs.jl

A Julia framework for implementing FFTs
MIT License
125 stars 32 forks source link

Use type of primal output in convert in chain rules #114

Closed gaurav-arya closed 1 year ago

gaurav-arya commented 1 year ago

Resolves #115 but not #112 (real-to-complex plans are not tested by Zygote anyway, since Zygote's rules for them are incorrect, so this does fix upstream).

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04% :warning:

Comparison is base (ee9f1b8) 93.57% compared to head (f961902) 93.54%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #114 +/- ## ========================================== - Coverage 93.57% 93.54% -0.04% ========================================== Files 5 5 Lines 420 418 -2 ========================================== - Hits 393 391 -2 Misses 27 27 ``` | [Files Changed](https://app.codecov.io/gh/JuliaMath/AbstractFFTs.jl/pull/114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaMath) | Coverage Δ | | |---|---|---| | [ext/AbstractFFTsChainRulesCoreExt.jl](https://app.codecov.io/gh/JuliaMath/AbstractFFTs.jl/pull/114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaMath#diff-ZXh0L0Fic3RyYWN0RkZUc0NoYWluUnVsZXNDb3JlRXh0Lmps) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.