move `dims` arg to keyword?

JuliaMath / AbstractFFTs.jl

A Julia framework for implementing FFTs

MIT License

126 stars 32 forks source link

move `dims` arg to keyword? #15

Open ssfrr opened 6 years ago

ssfrr commented 6 years ago

It seems like the convention in Base is (as of recently?) to have dims be a keyword argument. Should AbstractFFT match that convention, rather than as a positional argument?

carstenbauer commented 5 years ago

Was about to open an issue for this. 100% agree.

roflmaostc commented 3 days ago

Shall we do that? Does it break anything? We could still leave the standard second argument.