search

JuliaMath / AbstractFFTs.jl

A Julia framework for implementing FFTs
MIT License
125 stars 32 forks source link

Update actions #93

Closed devmotion closed 1 year ago

devmotion commented 1 year ago

This PR updates the Github actions, switches to julia-actions/cache and adds proper versioning to all actions (with dependabot we don't have to worry about outdated actions but rather about breaking updates IMO).

Closes #90. Closes #92. Closes #91.

gaurav-arya commented 1 year ago

Code coverage (upload) doesn't work with the updates here. See the error logged for the codecov-action in e.g. https://github.com/JuliaMath/AbstractFFTs.jl/actions/runs/4428264794/jobs/7767085981

ararslan commented 1 year ago

Doesn't look obviously related to me. Open source repositories don't require a token for submitting coverage information to Codecov so if it's having trouble with the GitHub API then that's either on Codecov's end or GitHub's (or both).

devmotion commented 1 year ago

Also it seems codecov was already updated on the master branch before this PR: #90 And there the action ran successfully, eg in https://github.com/JuliaMath/AbstractFFTs.jl/actions/runs/4428612759/jobs/7767949971

gaurav-arya commented 1 year ago

I see, perhaps it's independent then. https://github.com/codecov/codecov-action/issues/557 <- thought it might be related because this issue mentions that upgrading caused sporadic failures

devmotion commented 1 year ago

Based on this issue it seems intermittent issues occur quite regularly but possibly one could avoid them by adding the CODECOV_TOKEN as a secret (and to the action, of course), even though it should not be needed for public repos according to the docs.

devmotion commented 1 year ago

As an additional datapoint, the action did also succeed on the master branch when this PR was merged: https://github.com/JuliaMath/AbstractFFTs.jl/actions/runs/4438818860/jobs/7790407281